expand/CCash
1
0
Fork 0
mirror of https://github.com/Expand-sys/CCash synced 2025-12-17 16:42:13 +11:00
Code Issues Projects Releases Packages Wiki Activity Actions

🐎 max base64 header size calculated compile time based on max name

Browse source
This commit is contained in:
EntireTwix 2021-07-09 21:59:27 -07:00
parent 5a6a4180a0
commit b91e928286
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/user_filter.cpp
View file

@ -9,13 +9,13 @@ void UserFilter<set_body_flag, require_admin>::doFilter(const HttpRequestPtr &re
FilterChainCallback &&fccb) FilterChainCallback &&fccb)
{ {
std::string_view auth_header = req->getHeader("Authorization"); std::string_view auth_header = req->getHeader("Authorization");
if (auth_header.size() > 6 && auth_header.size() <= 688) //"Basic " + (username + ':' + password) * 4/3 if (auth_header.size() > 6 && auth_header.size() <= ((max_name_size + 256) * 4) / 3) //"Basic " + (username + ':' + password) * 4/3
{ {
if (auth_header.substr(0, 6) == "Basic ") if (auth_header.substr(0, 6) == "Basic ")
{ {
std::string_view base64_input = auth_header.substr(6); std::string_view base64_input = auth_header.substr(6);
static thread_local char result_buffer[511]; //(255 username + ':' + 255 password) static thread_local char result_buffer[max_name_size + 256]; //(username + ':' + 255 password)
std::memset(result_buffer, 0, 511); std::memset(result_buffer, 0, max_name_size + 256);
size_t new_sz; size_t new_sz;
base64_decode(base64_input.data(), base64_input.size(), result_buffer, &new_sz, 0); base64_decode(base64_input.data(), base64_input.size(), result_buffer, &new_sz, 0);