diff --git a/include/log.hpp b/include/log.hpp index 21c862a..2567ac8 100644 --- a/include/log.hpp +++ b/include/log.hpp @@ -7,31 +7,22 @@ struct Log { std::vector data; - void AddTrans(Transaction &&v) + void AddTrans(Transaction &&t) { - if (data.capacity() == data.size() && data.size() < max_log_size) //if memory reserved is full and max isnt reached + if (data.size() == max_log_size) // If we hit the max size { - if (data.size() + pre_log_size > max_log_size) //if prefetched memory is larger then max + for (uint32_t i = 0; i < data.size() - 1; i--) // Make room at the back { - data.reserve(max_log_size); //just allocate max - } - else - { - data.reserve(data.size() + pre_log_size); //prefetching memory + data[i - 1] = std::move(data[i]); // Shifts everything left } + data[data.size() - 1] = std::move(t); // Place new in opened spot + return; } - if (data.size() == max_log_size) + else if (data.size() == data.capacity()) // If we haven't hit the max but hit capacity { - for (size_t i = 0; i < data.size() - 1; ++i) - { - data[i] = std::move(data[i + 1]); - } - data[data.size() - 1] = std::move(v); - } - else - { - data.push_back(std::move(v)); + data.reserve(data.capacity() + pre_log_size); // Reserve more memory } + data.push_back(std::move(t)); // In either case we have space under max length, move to new spot } Json::Value Serialize() const { diff --git a/include/user.hpp b/include/user.hpp index 205aeb1..473c720 100644 --- a/include/user.hpp +++ b/include/user.hpp @@ -36,17 +36,17 @@ struct User { if (log_j.size()) { - unsigned size = ((log_j.size() / pre_log_size) + 1) * pre_log_size; // Ensures that we have a log size aligned on a multiple of `pre_log_size` - log.data.reserve(size); // Ensures that the log size is under `max_log_size` - size = std::min(log_j.size(), max_log_size); - log.data.resize(size); - for (uint32_t i = 0; i < size; ++i) + log.data.reserve( + std::min(((log_j.size() / pre_log_size) + 1) * pre_log_size, max_log_size) + ); // Ensures that the log size is under `max_log_size` and is aligned on multiple of `pre_log_size` + for (uint32_t i = 0; i < std::min(log_j.size(), max_log_size); i++) //Matches the logs { - log.data[i] = std::move(Transaction( + log.data.push_back(std::move(Transaction( log_j[i]["from"].asCString(), log_j[i]["to"].asCString(), log_j[i]["amount"].asUInt(), - log_j[i]["time"].asUInt64())); + log_j[i]["time"].asUInt64() + ))); } } } diff --git a/main.cpp b/main.cpp index 962574e..a2a72fc 100644 --- a/main.cpp +++ b/main.cpp @@ -22,15 +22,9 @@ void SaveSig(int s) int main(int argc, char **argv) { - static_assert(pre_log_size <= max_log_size, "`max_log_size` must be larger than `pre_log_size`."); - if constexpr (max_log_size) - { - if (max_log_size % pre_log_size) - { - std::cerr << "`max_log_size` must be a multiple of `pre_log_size`."; - return 0; - } - } + // Static assertations for logging only (!max_log_size) + static_assert(!max_log_size || pre_log_size < max_log_size, "`max_log_size` must be larger than `pre_log_size`."); + static_assert(!max_log_size || !(max_log_size % pre_log_size), "`max_log_size` must be a multiple of `pre_log_size`."); if (argc != 4) {