From a561742347482e83529440e359e4d0793e9d798e Mon Sep 17 00:00:00 2001
From: EntireTwix <willkatz.dev@gmail.com>
Date: Sat, 3 Jul 2021 19:10:32 -0700
Subject: [PATCH] :art: simplified DelUser()

---
 src/bank.cpp | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/src/bank.cpp b/src/bank.cpp
index 827e3f7..9334f10 100644
--- a/src/bank.cpp
+++ b/src/bank.cpp
@@ -187,17 +187,18 @@ BankResponse Bank::DelUser(const std::string &name) noexcept
     std::shared_lock<std::shared_mutex> lock{size_l};
 #if RETURN_ON_DEL
     uint32_t bal;
-    if (users.erase_if(name, [this, &bal, &name](User &u) {
+    if (users.if_contains(name, [this, &bal](const User &u) {
             bal = u.balance;
-            return true;
         }))
-#else
-    if (users.erase(name))
-#endif
     {
-#if RETURN_ON_DEL
-        users.modify_if(return_account, [&bal](User &u) { u.balance += bal; });
+        users.modify_if(return_account, [ this, bal ](User & u))
+        {
+            u.balance += bal;
+        }
+    }
 #endif
+    if (users.erase(name))
+    {
 #if CONSERVATIVE_DISK_SAVE
 #if MULTI_THREADED
         save_flag.SetChangesOn();