From 46c9eb7b7e8db16fd2f122ae7d099085da3dd515 Mon Sep 17 00:00:00 2001
From: EntireTwix <willkatz.dev@gmail.com>
Date: Sun, 4 Apr 2021 18:21:27 -0700
Subject: [PATCH] :fire: removed Save changes

---
 include/bank.hpp | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/include/bank.hpp b/include/bank.hpp
index 47cfefa..7c3d57f 100644
--- a/include/bank.hpp
+++ b/include/bank.hpp
@@ -120,23 +120,17 @@ public:
         std::ofstream user_save("users.json");
         Json::Value temp;
 
-        std::vector<std::string> temp_names;
-        temp_names.reserve(users.size());
         {
             std::unique_lock<std::shared_mutex> lock{save_lock}; //grabbing it from any busy add/del opperations
             for (const auto &u : users)
             {
-                temp_names.push_back(u.first);
+                //we know it contains this key but we call this func to grab mutex
+                users.if_contains(u.first, [&temp, &u](const User &u_val) {
+                    temp[u.first] = u_val.Serialize();
+                });
             }
         }
 
-        for (const std::string &s : temp_names)
-        {
-            users.if_contains(s, [&temp, &s](const User &u) {
-                temp[s] = u.Serialize();
-            });
-        }
-
         writer->write(temp, &user_save);
         user_save.close();
     }