expand/CCash
1
0
Fork 0
mirror of https://github.com/Expand-sys/CCash synced 2026-03-22 20:47:10 +11:00
Code Issues Projects Releases Packages Wiki Activity Actions

🐛 concurrent del user & adding log entry would allow a ghost log to be made

Browse source
This commit is contained in:
EntireTwix 2021-04-21 21:42:30 -07:00
parent 7d38974ba0
commit 417f52253b
1 changed files with 16 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
include/bank.hpp
View file

@ -128,18 +128,22 @@ public:
Transaction temp(a_name, b_name, amount); Transaction temp(a_name, b_name, amount);
Transaction temp2(a_name, b_name, amount); Transaction temp2(a_name, b_name, amount);
users.if_contains(a_name, [&temp, &a_name](const User &u) {
if (logs.try_emplace_l(a_name, [&temp](Log &l) { l.AddTrans(std::move(temp)); })) if (logs.try_emplace_l(a_name, [&temp](Log &l) { l.AddTrans(std::move(temp)); }))
{ {
logs.modify_if(a_name, [&temp](Log &l) { logs.modify_if(a_name, [&temp](Log &l) {
l.AddTrans(std::move(temp)); l.AddTrans(std::move(temp));
}); });
} }
});
users.if_contains(a_name, [&temp, &a_name](const User &u) {
if (logs.try_emplace_l(b_name, [&temp2](Log &l) { l.AddTrans(std::move(temp2)); })) if (logs.try_emplace_l(b_name, [&temp2](Log &l) { l.AddTrans(std::move(temp2)); }))
{ {
logs.modify_if(b_name, [&temp2](Log &l) { logs.modify_if(b_name, [&temp2](Log &l) {
l.AddTrans(std::move(temp2)); l.AddTrans(std::move(temp2));
}); });
} }
});
} }
return state; return state;