expand/CCash
1
0
Fork 0
mirror of https://github.com/Expand-sys/CCash synced 2025-12-17 08:32:13 +11:00
Code Issues Projects Releases Packages Wiki Activity Actions

🔥🐎 changed local array to static thread_local buffer

Browse source
This commit is contained in:
EntireTwix 2021-07-09 18:30:19 -07:00
parent db5a54175c
commit 2e991da613
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/user_filter.cpp
View file

@ -14,11 +14,11 @@ void UserFilter<set_body_flag, require_admin>::doFilter(const HttpRequestPtr &re
if (auth_header.substr(0, 6) == "Basic ") if (auth_header.substr(0, 6) == "Basic ")
{ {
std::string_view base64_input = auth_header.substr(6); std::string_view base64_input = auth_header.substr(6);
std::array<char, 511> base64_result; //(255 username + ':' + 255 password) static char result_buffer[511]{0}; //(255 username + ':' + 255 password)
size_t new_sz; size_t new_sz;
base64_decode(base64_input.data(), base64_input.size(), base64_result.begin(), &new_sz, 0); base64_decode(base64_input.data(), base64_input.size(), result_buffer, &new_sz, 0);
std::string_view results_view(base64_result.begin(), new_sz); std::string_view results_view(result_buffer, new_sz);
std::size_t middle = results_view.find(':'); std::size_t middle = results_view.find(':');
if (middle != std::string::npos) if (middle != std::string::npos)
{ {
@ -31,6 +31,7 @@ void UserFilter<set_body_flag, require_admin>::doFilter(const HttpRequestPtr &re
if (bank.VerifyPassword(username.str, password.str)) if (bank.VerifyPassword(username.str, password.str))
{ {
fccb(); fccb();
std::memset(result_buffer, 0, 511);
return; return;
} }
} }
@ -45,10 +46,12 @@ void UserFilter<set_body_flag, require_admin>::doFilter(const HttpRequestPtr &re
req->setParameter("name", username.str); req->setParameter("name", username.str);
} }
fccb(); fccb();
std::memset(result_buffer, 0, 511);
return; return;
} }
} }
} }
std::memset(result_buffer, 0, 511);
} }
} }
const auto &resp = HttpResponse::newCustomHttpResponse(BankResponse(k401Unauthorized, "\"Invalid Credentials\"")); const auto &resp = HttpResponse::newCustomHttpResponse(BankResponse(k401Unauthorized, "\"Invalid Credentials\""));