expand/CCash
1
0
Fork 0
mirror of https://github.com/Expand-sys/CCash synced 2025-12-16 16:12:14 +11:00
Code Issues Projects Releases Packages Wiki Activity Actions

🐛🔥🔒 possible safety concern if interior while auto saving

Browse source 
May corrupt as static, one thread could clear as the other is copying for example
This commit is contained in:
William Katz 2021-07-15 01:47:27 -07:00 committed by GitHub
parent cc17c3f8d3
commit 2d62f51006
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/bank.cpp
View file

@ -289,12 +289,12 @@ const char *Bank::Save()
)
{
#endif
static std::ofstream users_save(users_location, std::ios::out | std::ios::binary);
std::ofstream users_save(users_location, std::ios::out | std::ios::binary);
if (!users_save.is_open())
{
throw std::invalid_argument("Cannot access saving file\n");
}
static bank_dom::Global users_copy;
bank_dom::Global users_copy;
users_copy.users.clear();
users_copy.keys.clear();
users_copy.users.reserve(users.size());
@ -310,7 +310,7 @@ const char *Bank::Save()
});
}
}
static FBE::bank_dom::GlobalFinalModel writer;
FBE::bank_dom::GlobalFinalModel writer;
writer.serialize(users_copy);
if (!writer.verify())
{