expand/CCash
1
0
Fork 0
mirror of https://github.com/Expand-sys/CCash synced 2025-12-17 00:22:14 +11:00
Code Issues Projects Releases Packages Wiki Activity Actions

🐎 removed thread safety locks as the phmap will handle thread safety

Browse source
This commit is contained in:
EntireTwix 2021-04-01 21:24:29 -07:00
parent dd09559253
commit 030d5d4a3e
1 changed files with 1 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
include/user.hpp
View file

@ -8,10 +8,6 @@ private:
uint_fast64_t balance; uint_fast64_t balance;
std::string password; std::string password;
//for read/write of object's state concurrently
std::mutex bal_lock;
std::mutex pass_lock;
public: public:
/** /**
* @brief User constructor * @brief User constructor
@ -30,7 +26,6 @@ public:
bool ChangePassword(const std::string &attempt, std::string &&new_pass) bool ChangePassword(const std::string &attempt, std::string &&new_pass)
{ {
std::lock_guard<std::mutex> lock{pass_lock};
const bool state = (password == attempt); const bool state = (password == attempt);
if (state) if (state)
{ {
@ -50,14 +45,7 @@ public:
*/ */
static bool SendFunds(User &a, User &b, uint_fast64_t amount, const std::string &attempt) static bool SendFunds(User &a, User &b, uint_fast64_t amount, const std::string &attempt)
{ {
bool state; const bool state = (a.password == attempt) && (a.balance >= amount);
{
std::lock_guard<std::mutex> lock{a.pass_lock};
state = (a.password == attempt);
}
std::scoped_lock<std::mutex, std::mutex> lock{a.bal_lock, b.bal_lock};
state = state && (a.balance >= amount);
if (state) if (state)
{ {
a.balance -= amount; a.balance -= amount;